[foreign-memaccess+abi] RFR: 8263018: Improve API for lifecycle of native resources [v15]

[Paul Sandoz]

On Fri, 19 Mar 2021 16:01:53 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/MemoryScope.java line 192:
>> 
>>> 190:      * upon subsequent requests.
>>> 191:      */
>>> 192:     public SegmentAllocator allocator() {
>> 
>> Potentially `MemoryScope` could implement `SegmentAllocator` then there is no need for this method?
>> 
>> And then on `SegmentAllocator`:
>>     static SegmentAllocator scoped(ResourceScope scope) {
>>         return (MemoryScope) Objects.requireNonNull(scope);
>>     }
>
> Yes - I guess I didn't want to blur the two concepts too much - if we go down that path I think users will be able to cast a ResourceScope into a SegmentAllocator?

They could, but they should not since it's an implementation detail. (FWIW I don't think there is any impact to the integrity of the implementation.)

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/466