[foreign-jextract] RFR: 8263018: Improve API for lifecycle of native resources [v2]

[Maurizio Cimadamore]

On Wed, 24 Mar 2021 13:09:23 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 98 commits:
>> 
>>  - Merge branch 'foreign-jextract' into jextract+resourceScope
>>  - Merge branch 'foreign-memaccess+abi' into jextract+resourceScope
>>  - Merge branch 'foreign-jextract' into jextract+resourceScope
>>  - Add overloads accepting ResourceScope parameter
>>  - Merge branch 'resourceScope' into jextract+resourceScope
>>  - Add ResourceScope overloads in CLinker
>>    Rewrite StdLib test not to use NativeScope
>>    Tweak names of allocator factories
>>    Fix javadoc
>>  - All tests pass
>>    * Fix upcall overload taking NativeScope
>>    * Generate NativeScope in output package
>>    * Add overload for functions returning a struct so than a NativeScope can be passed
>>    * Removed some now unused features from RuntimeHelper (ti make scope non-transferrable)
>>    * Fixup vararg invoker to deal with allocator parameters
>>    * Fixup tests to (a) depend on the generated NativeScope and (b) not to use TWR with segments directly
>>    Notes:
>>    * the internal libclang probably needs to be re-generated
>>  - Merge branch 'resourceScope' into jextract+resourceScope
>>  - Fix javadoc of SegmentAllocator
>>  - Address rest of review comments from Paul
>>  - ... and 88 more: https://git.openjdk.java.net/panama-foreign/compare/4e696684...6316ddca
>
> src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/HeaderFileBuilder.java line 99:
> 
>> 97:                 emitFunctionWrapperNoAllocatorOverload(javaName, functionInfo);
>> 98:                 emitFunctionWrapperScopedOverload(javaName, functionInfo);
>> 99:             }
> 
> With the emitFunctionWrapper call above this, don't we get a publicly accessible function wrapper that will always throw a WrongMethodTypeException because it's missing an allocator argument? Maybe it should be conditionally made private? (since the other 2 functions reference it, it's still needed).

I see what you mean.

> src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/TypedefBuilder.java line 78:
> 
>> 76:         append("}\n");
>> 77:         decrAlign();
>> 78:     }
> 
> I don't get why this is removed. Was it not being used?

It was a leftover from when we were using the @C annotation. These methods don't do anything special other than allocating a C_POINTER

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/474