[foreign-jextract] RFR: 8263018: Improve API for lifecycle of native resources [v2]

[Jorn Vernee]

On Wed, 24 Mar 2021 13:47:36 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> src/jdk.incubator.jextract/share/classes/jdk/internal/clang/libclang/RuntimeHelper.java line 93:
>> 
>>> 91:                     return variadic ?
>>> 92:                         VarargsInvoker.make(addr, mt, fdesc) :
>>> 93:                         LINKER.downcallHandle(addr, DEFAULT_ALLOCATOR, mt, fdesc);
>> 
>> Using a managed segment by default here also seems like asking for trouble, since we don't know how the returned struct is going to be used (e.g. might be projected into an address).
>> 
>> Would seem more robust to have a throwing allocator used here for functions that don't have MS as a return type, and then determine on a case-by-case basis which scope to use for MS returns. (sorry)
>
> Uhm.. in the new generated code this is not a problem - e.g. this is not what RuntimeHelper looks like in the new world. This is mostly a way to get libclang up and running. We could of course do what you suggest, I was unsure whether now is the time to do it (e.g. won't we regenerated libclang anyway?)

Ah, ok. That makes sense.

>> src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/FunctionalInterfaceBuilder.java line 113:
>> 
>>> 111:                 delim = ", ";
>>> 112:             }
>>> 113:             append(") -> {\n");
>> 
>> Looks like this is also switching from anon classes to lambdas?
>
> yes - I changed it since I was there

Ok, LGTM.

>> src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/TypedefBuilder.java line 78:
>> 
>>> 76:         append("}\n");
>>> 77:         decrAlign();
>>> 78:     }
>> 
>> I don't get why this is removed. Was it not being used?
>
> It was a leftover from when we were using the @C annotation. These methods don't do anything special other than allocating a C_POINTER

Ok. (It doesn't look all that interesting either :) )

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/474