[foreign-jextract] RFR: 8263018: Improve API for lifecycle of native resources [v2]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Wed Mar 24 15:23:11 UTC 2021


On Wed, 24 Mar 2021 15:01:43 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> src/jdk.incubator.jextract/share/classes/jdk/internal/clang/libclang/RuntimeHelper.java line 97:
>> 
>>> 95:     }
>>> 96: 
>>> 97:     static final MethodHandle downcallHandle(LibraryLookup[] LIBRARIES, String name, String desc, FunctionDescriptor fdesc, boolean variadic, NativeScope scope) {
>> 
>> This seems unused. Should this have gone into the template file instead maybe?
>
> What do you think of this? This method still seems unused in the latest version

This is generated code, I don't think it's worth making changes on code that will be overwritten when we regenerate this. There are loads of methods that are unused in the libclang port (because jextract doesn't use all libclang functions).

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/474


More information about the panama-dev mailing list