[foreign-memaccess+abi] RFR: 8263459: Add better support for restricted methods [v2]

[Maurizio Cimadamore]

On Fri, 26 Mar 2021 17:21:47 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> When a Panama native restricted method is called, we will no require that the caller module (which could be ALL-UNNAMED) has been whitelisted accordingly, on the command line, using this flag:
>> 
>> --enable-native-access=<modulename>
>> 
>> In other words, this work replaces the hacky -Dforeign.restricted=permit property with a system which works in tandem with the Java module system.
>> 
>> The current PR includes subset of the earlier PR 
>> 
>> https://github.com/openjdk/panama-foreign/pull/471
>> 
>> The 'fail fast' aspect (jlink plugin to mark "NativeAccess" calling modules and issuing error if those modules were not mentioned in --enable-native-access) has been removed in this new PR.
>
> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Hotspot implementation of link time check is replaced with CallerSensitive pure Java check.

Looks good - but there's still some VM code left which I don't think is needed (if we go for this approach).

src/hotspot/share/classfile/classFileParser.cpp line 2132:

> 2130:       return _method_Scoped;
> 2131:     }
> 2132:     case VM_SYMBOL_ENUM_NAME(jdk_internal_vm_annotation_NativeAccess_signature): {

I don't think this stuff is needed anymore? The annotation should just be there for javadoc puprposes.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/472