[foreign-memaccess+abi] RFR: 8264386: LibraryLookup should be more friendly with implicit unloading [v2]
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Mon Mar 29 20:52:01 UTC 2021
On Mon, 29 Mar 2021 17:58:34 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Add @NativeAccess annotations and @CallerSensitive check on LibraryLookup::lookup(String, MemoryLayout)
>> - Merge branch 'foreign-memaccess+abi' into resourceScope+libraries
>> - Initial push
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/LibraryLookup.java line 69:
>
>> 67: /**
>> 68: * Looks up a symbol with given name in this library. The returned memory address maintains a strong reference to this lookup object.
>> 69: * @param name the symbol name. This method can be useful to lookup function symbols in a foreign library.
>
> "This method can be useful to lookup function symbols in a foreign library." seems like this wasn't meant to be put on the parameter?
true
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/480
More information about the panama-dev
mailing list