[foreign-memaccess+abi] RFR: 8264280: Foreign linker should be more friendly with implicit scopes (followup)

[Maurizio Cimadamore]

On Tue, 30 Mar 2021 14:00:58 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> The newly added test sometimes fails spuriously. This is caused by the fact that the library is loaded to an address that is a multiple of the expected layout constraints.
>> The fix is to make the test tolerant to this situation - and check that, if no exception is thrown, the symbol alignment must be the same as the one specified by the layout.
>
> test/jdk/java/foreign/TestLibraryLookup.java line 112:
> 
>> 110:             if ((segment.address().toRawLongValue() % layout.byteAlignment()) != 0) {
>> 111:                 fail("Unaligned address");
>> 112:             }
> 
> maybe just use assertFalse here?

why? isn't fail supposed to be exactly that?

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/484