[foreign-memaccess+abi] RFR: 8264434: Remove ResourceScope-less overload from API [v2]

[Jorn Vernee]

On Tue, 30 Mar 2021 15:02:40 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This patch does a bunch of API cleanups related to overloaded methods:
>> 
>> * Remove ResouceScope-less overloads (in MemorySegment, CLinker, MemoryAddress, VaList)
>> * Remove ResourceScope factory overloads which take Object attachment (in ResourceScope)
>> * Fixup javadoc
>> 
>> The changes are mostly mechanical - e.g. an extra ResourceScope.ofImplicit() is added wherever needed.
>> Similarly, for address to segment conversion, an extra ResourceScope.globalScope() is added.
>> 
>> The term *implicit* has been selected to denote the subset of scopes that are not only managed by a Cleaner, but that do not play into explicit deallocation.
>> 
>> So, ResourceScope.ofImplicit() returns a new implicit scope, whereas ResourceScope.globalScope, returns a constant implicit scope which is assumed to be alive for the entire duration of the application.
>> 
>> A new predicate has been added on ResourceScope, namely `isImplicit` which allows client to see whether a segment supports deterministic closure (we used to have a similar predicate, but was called `isCloseable` and that created confusion w.r.t. the semantics of close() - the new naming is more apt, in that it clearly reflects a permanent property of the resource scope).
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix more javadoc references

LGTM. I agree with Paul that it would be nice to rename `ofXYZ` factories to something that is more amenable to static importing (as also discussed offline), e.g. `ResourceScope.ofImplicit()` -> `ResourceScope.implicit()` to be consistent with `SegmentAllocator.implicit()`.

src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/ResourceScope.java line 149:

> 147:     /**
> 148:      * Is this resource scope an <em>implicit scope</em>?
> 149:      * @return true if this scope is an an <em>implicit scope</em>.

Typo
Suggestion:

     * @return true if this scope is an <em>implicit scope</em>.

-------------

Marked as reviewed by jvernee (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/485