[vectorIntrinsics] RFR: 8244490: [vector] Move Vector API micro benchmarks under test/micro

Marcus G K Williams github.com+168222+mgkwill at openjdk.java.net
Mon May 3 21:24:59 UTC 2021


On Mon, 3 May 2021 21:12:59 GMT, Marcus G K Williams <github.com+168222+mgkwill at openjdk.org> wrote:

>> @PaulSandoz @katyapav Tried my hand at a draft of https://bugs.openjdk.java.net/browse/JDK-8244490. 
>> 
>> If I am on the right track, any feedback or suggestions would be helpful.
>
>> @PaulSandoz @katyapav Tried my hand at a draft of https://bugs.openjdk.java.net/browse/JDK-8244490.
>> 
>> If I am on the right track, any feedback or suggestions would be helpful.
> 
> I was able to run using `make test TEST="micro:Int64Vector" MICRO="FORK=2;WARMUP_ITER=5;" CONF=linux-x86_64-server-release` with this patch.

> @mgkwill thank you for doing this. I need to check out the PR locally and give it a test drive, but eyeballing it looks like you are on track. It unfortunately means there is some duplication in generation logic, but that seems unavoidable. Moving to this area is a prerequisit for integration into the mainline.

Happy to do it. I stumbled upon the issue when I needed to run some of the tests. It seemed like something helpful and I thought it would be nice to get benchmarks into mainline. Let me know how the local test works.
> 
> Separate from moving the location, but related to mainline integration, I have concerns as to the number of benchmarks generated. It may be we have to curate a default smaller set, but enable the ability for someone to generate more for local testing. We could consider that later on.

Sounds reasonable to me. More guidance here and I'm happy to help there also.

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/77


More information about the panama-dev mailing list