[foreign-memaccess+abi] RFR: 8265222: revisit foreign library loading [v2]

[Athijegannathan Sundararajan]

On Thu, 6 May 2021 13:34:55 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Windows hack for malloc/free. fixed javadoc comments. benchmarks use new APIs. removed psapi.h header include.
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java line 142:
> 
>> 140:      * restricted methods, and use safe and supported functionalities, where possible.
>> 141:      *
>> 142:      * @param name the symbol name.
> 
> Suggestion:
> 
>      * @param the name of the symbol to be searched.

will do

> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java line 143:
> 
>> 141:      *
>> 142:      * @param name the symbol name.
>> 143:      * @return the memory address associated with the library symbol (if any).
> 
> Suggestion:
> 
>      * @return the address of a symbol with given name in one of the native libraries associated with the caller's classloader (if any).

will do

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/526