[foreign-memaccess+abi] RFR: 8265222: revisit foreign library loading [v3]

[Maurizio Cimadamore]

On Thu, 6 May 2021 14:23:31 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> LibraryLookup removed. CLinker.findNative added. System.loadLibrary has to be used to load library
>
> Athijegannathan Sundararajan has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Update src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java
>    
>    Co-authored-by: Maurizio Cimadamore <54672762+mcimadamore at users.noreply.github.com>
>  - Update src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/package-info.java
>    
>    Co-authored-by: Maurizio Cimadamore <54672762+mcimadamore at users.noreply.github.com>
>  - code review changes for javadoc and code comments.

Some more javadoc comments

Marked as reviewed by mcimadamore (Committer).

src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java line 143:

> 141:      * restricted methods, and use safe and supported functionalities, where possible.
> 142:      *
> 143:      * @param name of the symbol to be searched.

Suggestion:

     * @param name the name of the symbol to be searched.

src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/package-info.java line 120:

> 118:  * }</pre>
> 119:  *
> 120:  * Here, we lookup the {@code strlen} symbol; this assumes that a library containing the `strlen` symbol has been loaded

Suggestion:

 * Here, we lookup the {@code strlen} symbol; this assumes that a library containing the {@code strlen} symbol has been loaded

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/526