[vectorIntrinsics] RFR: 8266720: Wrong implementation in LibraryCallKit::inline_vector_shuffle_iota
Paul Sandoz
psandoz at openjdk.java.net
Thu May 13 15:51:24 UTC 2021
On Thu, 13 May 2021 01:45:11 GMT, Wang Huang <whuang at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/vectorapi/TestVectorShuffleIota1024.java line 38:
>>
>>> 36: * @bug 8266720
>>> 37: * @modules jdk.incubator.vector
>>> 38: * @run testng/othervm compiler.vectorapi.TestVectorShuffleIotaByte1024
>>
>> Perhaps the test can be annotated, declaring it should only execute on ARM/SVE platforms. See the use of the `@requires` clause used in other JDK tests.
>
> Thank you for you review. I think this test is used for any arch which has `ByteVector.SPECIES_MAX == 1024`.
But we know which arches don't support, x86, PPC etc.
I am unsure why existing shuffle tests do not catch this problem. In fact i would prefer we focus on that if we can rather than adding a specific test. Would you mind looking to see if see if we can expand on the existing `shuffleTest`?
-------------
PR: https://git.openjdk.java.net/panama-vector/pull/81
More information about the panama-dev
mailing list