[vectorIntrinsics+mask] RFR: 8266621: Add masking support for unary/ternary vector intrinsics
Xiaohong Gong
xgong at openjdk.java.net
Thu May 20 09:55:52 UTC 2021
On Thu, 13 May 2021 16:29:40 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
>> Similar with [1], this patch adds the masking support for `unary/ternary` vector intrinsics. It adds the mask information to the original intrinsic methods which are called both by masked and non-masked unary/ternary operations. For non-masked operations, the mask class and value are set to null.
>>
>> Also change to use the `"binaryMaskedOp"` for vector mask logical operations instead of` "binaryOp"`. So that all the original nary intrinsics and hotspot implementation can be removed.
>>
>> Note that this patch only contains the Vector API java implementation and the hotspot intrinsics changes. No compiler mid-end and backend implementations are included.
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8264563
>
> I think what you have is fine, lets get the code in the branch and iterate. It's easy to revisit naming decisions like this later.
@PaulSandoz @iwanowww , I'v rename all the masked op back to the original names. Could you please help to look at again? Waiting for your feedback, Thanks so much!
-------------
PR: https://git.openjdk.java.net/panama-vector/pull/80
More information about the panama-dev
mailing list