[vectorIntrinsics] RFR: Improve mask reduction operations on AVX [v3]

Mai Đặng Quân Anh duke at openjdk.java.net
Tue Nov 9 16:28:54 UTC 2021


On Tue, 9 Nov 2021 11:36:23 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Mai Đặng Quân Anh has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - support for non-bmi, some refinement
>>  - restore VectorStoreMaskNode, move logic to backend
>
> src/hotspot/cpu/x86/x86.ad line 8682:
> 
>> 8680:     __ vpmovmskb($dst$$Register, $xtmp$$XMMRegister, vlen_enc);
>> 8681:     // Mask generated out of partial vector comparisons/replicate/mask manipulation
>> 8682:     // operations needs to be clipped.
> 
> Please keep this comment intact.

Thank you very much for the review,
I put the comment in C2_MacroAssembler where the clip occurs. Is it okay for you?

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/158


More information about the panama-dev mailing list