[foreign-jextract] RFR: 8277830: jextract generated code should not depend on Java layouts

Maurizio Cimadamore mcimadamore at openjdk.java.net
Mon Nov 29 15:57:21 UTC 2021


On Mon, 29 Nov 2021 15:44:32 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/ToplevelBuilder.java line 245:
>> 
>>> 243:                 return "JAVA_CHAR.withBitAlignment(" + vl.bitAlignment() + ")";
>>> 244:             } else if (vl.carrier() == byte.class) {
>>> 245:                 return "JAVA_BYTE";
>> 
>> What about hyper-aligned bytes and booleans? Don't we always need a call to `withBitAlignment` ?
>
> Ah I guess this code is only called from the methods below.

yeah - this is just for the primitive layout that get added "by default".

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/620


More information about the panama-dev mailing list