[vectorIntrinsics+compress] RFR: 8274839: Intrinsic support for compress & expand VectorAPI [v2]

[Joshua Zhu]

On Wed, 6 Oct 2021 17:02:31 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Joshua Zhu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update
>
> src/hotspot/cpu/x86/x86.ad line 9249:
> 
>> 9247:   ins_pipe( pipe_slow );
>> 9248: %}
>> 9249: 
> 
> Did you intend this to be part of pull 144.

Done

> src/hotspot/share/opto/vectorIntrinsics.cpp line 2746:
> 
>> 2744: 
>> 2745:   bool is_compress = (opr == TypeInt::ONE);
>> 2746:   assert(is_compress, "Temporary assert. Will remove after enable expand.");
> 
> Let us remove this assert as arch_supports_vector will return false till we support expand in the .ad file.

Done.

> src/hotspot/share/opto/vectorIntrinsics.cpp line 2749:
> 
>> 2747:   int num_elem = vlen->get_con();
>> 2748:   int sopc = Op_CompressV;
>> 2749:   // int sopc = is_compress ? Op_CompressV : Op_ExpandV;
> 
> Better to uncomment 
> int sopc = is_compress ? Op_CompressV : Op_ExpandV;
> instead of forcing sopc.
> arch_supports_vector will return false for expand.

Done.

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/145