[foreign-memaccess+abi] RFR: API refresh - part two [v3]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Thu Oct 7 13:01:55 UTC 2021


On Wed, 6 Oct 2021 22:12:24 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix code snippet in SegmentAllocator::nativeAllocator
>
> test/jdk/java/foreign/TestByteBuffer.java line 500:
> 
>> 498:         f.createNewFile();
>> 499:         f.deleteOnExit();
>> 500:         MemorySegment.mapFile(f.toPath(), 0L, -1, FileChannel.MapMode.READ_WRITE, ResourceScope.newSharedScope());
> 
> Shared scope or implicit scope?

These were negative tests, so they should fail before even creating anything. Anyway, I've fixed this in the latest revision.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/591


More information about the panama-dev mailing list