[foreign-jextract] RFR: API refresh - part two (jextract edition) [v2]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Thu Oct 7 20:17:19 UTC 2021


On Thu, 7 Oct 2021 18:38:35 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/jdk.incubator.jextract/share/classes/jdk/internal/clang/LibClang.java
>>   
>>   Co-authored-by: Paul Sandoz <paul.d.sandoz at googlemail.com>
>
> src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/resources/RuntimeHelper.java.template line 36:
> 
>> 34:     private final static SymbolLookup SYMBOL_LOOKUP;
>> 35: 
>> 36:     final static SegmentAllocator CONSTANT_ALLOCATOR =
> 
> That's the same as the `IMPLICIT_ALLOCATOR`.

yes, but this one is referred to from the generated code, while IMPLICIT_ALLOCATOR is referred to by jextract code, hence the need for two constants. Ultimately we'll add a segment allocator constant, which will make this easier.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/594


More information about the panama-dev mailing list