[vectorIntrinsics+compress] RFR: 8274975: Add micro benchmark: ALIBABA selective store use case [v2]

Joshua Zhu jzhu at openjdk.java.net
Wed Oct 13 11:49:06 UTC 2021


On Mon, 11 Oct 2021 15:38:29 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Joshua Zhu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update
>
> test/micro/org/openjdk/bench/jdk/incubator/vector/bigdata/SelectiveStore.java line 43:
> 
>> 41: @Warmup(iterations = 5, time = 1)
>> 42: @Measurement(iterations = 10, time = 1)
>> 43: @Fork(value = 1, jvmArgsPrepend = {"--add-modules=jdk.incubator.vector", "--add-exports", "java.base/jdk.internal.vm.vector=ALL-UNNAMED", "-ea"})
> 
> The "--add-exports" should not be necessary?

Done. Thanks.

> test/micro/org/openjdk/bench/jdk/incubator/vector/bigdata/SelectiveStore.java line 91:
> 
>> 89: 
>> 90:   @Benchmark
>> 91:   @Threads(8)
> 
> Does it need to be a multi-threaded benchmark? If we can still measure the benefits with a single thread that may be more preferable, since it is simpler.

Done.

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/149


More information about the panama-dev mailing list