[foreign-memaccess+abi] RFR: Address failures in jdk.incubator.foreign benchmarks [v2]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Wed Oct 20 09:59:27 UTC 2021


On Wed, 20 Oct 2021 09:18:51 GMT, Julia Boes <jboes at openjdk.org> wrote:

>> This change addresses some failures in the jdk.incubator.foreign benchmarks, mainly caused by missing casts and missing native access.
>
> Julia Boes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   pass segment instead of its address

Looks very good - thanks for catching all these mistakes!

test/micro/org/openjdk/bench/jdk/incubator/foreign/BulkOps.java line 140:

> 138:     @OutputTimeUnit(TimeUnit.NANOSECONDS)
> 139:     public void segment_copy_static() {
> 140:         MemorySegment.copy(bytes, 0, segment, JAVA_INT, 0, bytes.length);

Good catch!

-------------

Marked as reviewed by mcimadamore (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/602


More information about the panama-dev mailing list