[foreign-memaccess+abi] Integrated: 8275332: Variadic functions don't work on Linux/AArch64
Nick Gasson
ngasson at openjdk.java.net
Fri Oct 22 10:50:36 UTC 2021
On Tue, 19 Oct 2021 08:54:24 GMT, Nick Gasson <ngasson at openjdk.org> wrote:
> Variable length argument lists are handled differently in the
> Mac/Windows and Linux ABIs on AArch64. Following the recent API refresh
> on the foreign-memaccess+abi branch the Mac behaviour was inadvertently
> applied on Linux too. This patch restores the correct behaviour on
> Linux and adds a CallArranger unit test so regressions can be more
> easily caught.
>
> I just added an extra varArgsOnStack argument to
> CallArranger.getBindings() as that seemed the simplest fix, although it
> could get unwieldy if there were too many configurable options.
This pull request has now been integrated.
Changeset: 87cfa79b
Author: Nick Gasson <ngasson at openjdk.org>
Committer: Jorn Vernee <jvernee at openjdk.org>
URL: https://git.openjdk.java.net/panama-foreign/commit/87cfa79ba80af7b79a5d9873fe093bed459b88ec
Stats: 166 lines in 7 files changed: 143 ins; 0 del; 23 mod
8275332: Variadic functions don't work on Linux/AArch64
Reviewed-by: mcimadamore, jvernee
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/601
More information about the panama-dev
mailing list