[foreign-memaccess+abi] RFR: 8255903: Enable multi-register return values for native invokers [v3]
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Wed Oct 27 11:01:36 UTC 2021
On Thu, 21 Oct 2021 13:34:39 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixup all platform stubs
>
> src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/SharedUtils.java line 398:
>
>> 396: // downcalls get the leading NativeSymbol/SegmentAllocator param as well
>> 397: if (!upcall) {
>> 398: closer = collectArguments(closer, insertPos++, reachabilityFenceHandle(NativeSymbol.class));
>
> This reachability fence for the target address is no longer needed I think. It is already being handled by the wrapper that acquires the scope of the target address. (https://github.com/openjdk/panama-foreign/blob/451eead47e7a1b6a0aedeca5cb2f32427b9c46dc/src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/SharedUtils.java#L511)
agree
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/603
More information about the panama-dev
mailing list