[foreign-memaccess+abi] RFR: 8255903: Enable multi-register return values for native invokers [v4]
Jorn Vernee
jvernee at openjdk.java.net
Fri Oct 29 12:20:50 UTC 2021
> Hi,
>
> This patch implements support for multi-register returns in native invokers, and removes the buffered invocation strategy for downcalls. This is achieved, essentially, by using an in memory return: the caller allocates a bit of memory, and the native invoker stub writes the values of the return register to that memory. Then, the post processing code reads the register values back from there.
>
> Currently, the target address of a downcall is handled separately from the other arguments. I initially implemented passing the IMR address the same way, but I realized the removal of the buffered invocation strategy affords us a better way of doing things: we can just make the target address and the IMR address part of the normal calling sequence, and remove a bunch of special-casing code to handle these. We now just use a binding recipe to unbox these arguments and shuffle them into registers, and the ABIDescriptor tells the native invoker stub which registers to pick up these arguments from.
>
> Thanks,
> Jorn
Jorn Vernee has updated the pull request incrementally with six additional commits since the last revision:
- Benchmark fix
- Rename FunctionDescriptor methods again
- Fix tests again
- Rename imr -> needsReturnBuffer
- Address small comments
- Fix failing tests
-------------
Changes:
- all: https://git.openjdk.java.net/panama-foreign/pull/603/files
- new: https://git.openjdk.java.net/panama-foreign/pull/603/files/1e309797..480cc9d4
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=panama-foreign&pr=603&range=03
- incr: https://webrevs.openjdk.java.net/?repo=panama-foreign&pr=603&range=02-03
Stats: 187 lines in 28 files changed: 11 ins; 8 del; 168 mod
Patch: https://git.openjdk.java.net/panama-foreign/pull/603.diff
Fetch: git fetch https://git.openjdk.java.net/panama-foreign pull/603/head:pull/603
PR: https://git.openjdk.java.net/panama-foreign/pull/603
More information about the panama-dev
mailing list