[vectorIntrinsics+mask] Integrated: 8272745: VectorAPI: Vector/Mask type cleanup for masked vector intrinsics
Eric Liu
eliu at openjdk.java.net
Thu Sep 2 17:06:15 UTC 2021
On Wed, 1 Sep 2021 01:26:11 GMT, Eric Liu <eliu at openjdk.org> wrote:
> Some of the VectorAPIs were inconsistent with their intrinsic
> declarations, and some of the type arguments were not precise enough as
> well. E.g., The return type of "unaryOp" should be a subtype of "Vector"
> instead of an all-purpose "Object" [1][2].
>
> The imprecise declarations and type arguments would not effect the
> correctness but bring bad readability and make the code hard to
> maintain. This patch is a cleanup for those mismatched declarations of
> VectorAPIs.
>
> [1] https://github.com/openjdk/panama-vector/blob/vectorIntrinsics%2Bmask/src/java.base/share/classes/jdk/internal/vm/vector/VectorSupport.java#L269
> [2] https://github.com/openjdk/panama-vector/blob/vectorIntrinsics%2Bmask/src/hotspot/share/classfile/vmIntrinsics.hpp#L812
This pull request has now been integrated.
Changeset: 859a7572
Author: Eric Liu <eliu at openjdk.org>
URL: https://git.openjdk.java.net/panama-vector/commit/859a75726d6b0b818cf45ba82eb6c3b42d7252cd
Stats: 581 lines in 4 files changed: 296 ins; 24 del; 261 mod
8272745: VectorAPI: Vector/Mask type cleanup for masked vector intrinsics
Co-authored-by: Paul Sandoz <psandoz at openjdk.org>
Reviewed-by: psandoz
-------------
PR: https://git.openjdk.java.net/panama-vector/pull/117
More information about the panama-dev
mailing list