[vectorIntrinsics+mask] RFR: 8273264: AArch64: [vector] Add missing rules for VectorMaskCast [v2]
Eric Liu
eliu at openjdk.java.net
Tue Sep 14 11:01:36 UTC 2021
On Mon, 13 Sep 2021 15:31:29 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
>> Eric Liu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - small fix
>>
>> Change-Id: I4f5b75c498a3daadf9938e64be5021c43068af67
>> - Merge remote-tracking branch 'upstream/vectorIntrinsics+mask' into masked-cast
>>
>> Change-Id: I5f9e0f627090bb914d496b757091461dbd6a7f72
>> - 8273264: AArch64: [vector] Add missing rules for VectorMaskCast
>>
>> This patch
>> 1. Adds missing rules for VectorMaskCast for compatible species, E.g.
>> ByteVector.SPECIES_64 --> ShortVector.SPECIES_128
>> 2. Fixes a matching failure on AArch64.
>>
>> The performance improves about 60% compared with the unintrinsified
>> version.
>>
>> Change-Id: I1bcfc5a09b93c5f4625f39bd3b6a146154f69ad7
>
> test/hotspot/jtreg/compiler/vectorapi/VectorMaskCastTest.java line 52:
>
>> 50:
>> 51:
>> 52: public class VectorMaskCastTest{
>
> Do we need to add such a test? We already have conversions tests, see sub-classes of `AbstractVectorConversionTest`.
I tested with those conversion tests before, but the method could not be intrinsified. I checked generated code and the new test cases could work.
-------------
PR: https://git.openjdk.java.net/panama-vector/pull/124
More information about the panama-dev
mailing list