[vectorIntrinsics+mask] RFR: 8273949: Intrinsic creation for VectorMask.toLong operation. [v3]

Jatin Bhateja jbhateja at openjdk.java.net
Wed Sep 22 08:21:57 UTC 2021


On Tue, 21 Sep 2021 17:14:30 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8273949: Review comments resolution.
>
> src/hotspot/cpu/x86/x86.ad line 8663:
> 
>> 8661: %}
>> 8662: 
>> 8663: instruct vmask_tolong_evex(rRegL dst, kReg mask) %{
> 
> The instructs with rRegL should be in ifdef _LP64.

Its already covered under _LP64

> src/hotspot/share/prims/vectorSupport.cpp line 441:
> 
>> 439:         case T_FLOAT: // fall-through
>> 440:         case T_DOUBLE: return Op_VectorMaskToLong;
>> 441:         default: fatal("MASK_TRUECOUNT: %s", type2name(bt));
> 
> MASK_TOLONG here? Also break is missing.

This is consistent with other case statements.

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/126


More information about the panama-dev mailing list