[foreign-jextract] RFR: 8274280: regenarate libclang binding in jextract module [v2]
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Fri Sep 24 13:06:00 UTC 2021
On Fri, 24 Sep 2021 13:02:18 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:
>> Moved CLayouts out of the generated code package. Except for libName & copyright header, no changes to the jextract generated code now.
>
> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>
> removed CLayouts. Using generated C_* layouts instead. Using ADDRESS in TypeImpl.java instead of C_POINTER.
Looks good!
src/jdk.incubator.jextract/share/classes/jdk/internal/clang/CLayouts.java line 26:
> 24: */
> 25:
> 26: package jdk.internal.clang;
This class should be removed. Other classes in the libclang package should use the C layouts that are generated in the main class header. Outside of the package, we should just use regular ValueLayouts (e.g. `ADDRESS`).
-------------
Marked as reviewed by mcimadamore (Committer).
PR: https://git.openjdk.java.net/panama-foreign/pull/580
More information about the panama-dev
mailing list