[vectorIntrinsics] RFR: 8283709: Add x86 back-end implementation for bit BIT_COUNT operation [v9]

Jatin Bhateja jbhateja at openjdk.java.net
Tue Apr 12 05:37:58 UTC 2022


On Mon, 11 Apr 2022 21:27:46 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8283709: Review comments resolved.
>
> src/hotspot/cpu/x86/x86.ad line 8660:
> 
>> 8658:               VM_Version::supports_avx512_bitalg()) ||
>> 8659:              (is_non_subword_integral_type(Matcher::vector_element_basic_type(n->in(1))) &&
>> 8660:               VM_Version::supports_avx512_vpopcntdq())));
> 
> Could be replaced by:
> predicate(is_pop_count_instr_target(Matcher::vector_element_basic_type(n->in(1))));
> Also no need to check for UsePopCountInstruction any where as it is only meant for scalar popcount.

Thanks,  I already cleaned this up, its used at couple of places and will refactor when I create mainline integration patch.

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/185


More information about the panama-dev mailing list