[vectorIntrinsics] RFR: 8283598: [vectorapi] Add new vector operation for compress and expand bits [v5]

[Sandhya Viswanathan]

On Thu, 14 Apr 2022 00:33:33 GMT, Smita Kamath <svkamath at openjdk.org> wrote:

>> Hi,
>> 
>> I've added support for new vector operations for compressing bits of integral vector types(Byte/Short/Integer/Long).
>> The implementation is based on Compress or Generalized Extract mentioned in Hackers Delight by Henry S. Warren, Jr.
>> The implementation does the following: given a mask and the number to be compressed, the bits of the number corresponding to the set mask bit are selected and compressed. 
>> 
>> Currently, this PR addresses only Java changes for compress bits operation. I've also updated the test framework.
>> Do review and share feedback.
>
> Smita Kamath has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed perf_scalar_tests, perf_tests and unit_tests template files from the commit

Rest of the patch looks good to me.

src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template line 528:

> 526: #end[intOrLong]
> 527:     }
> 528: 

Extra empty line could be removed from template.

test/jdk/jdk/incubator/vector/templates/Unit-header.template line 1505:

> 1503:     }
> 1504: 
> 1505: 

Extra empty line could be removed from template.

-------------

Marked as reviewed by sviswanathan (Committer).

PR: https://git.openjdk.java.net/panama-vector/pull/184