[vectorIntrinsics] RFR: 8283598: [vectorapi] Add new vector operation for compress and expand bits [v7]

Paul Sandoz psandoz at openjdk.java.net
Thu Apr 14 16:06:04 UTC 2022


On Thu, 14 Apr 2022 00:54:05 GMT, Smita Kamath <svkamath at openjdk.org> wrote:

>> Hi,
>> 
>> I've added support for new vector operations for compressing bits of integral vector types(Byte/Short/Integer/Long).
>> The implementation is based on Compress or Generalized Extract mentioned in Hackers Delight by Henry S. Warren, Jr.
>> The implementation does the following: given a mask and the number to be compressed, the bits of the number corresponding to the set mask bit are selected and compressed. 
>> 
>> Currently, this PR addresses only Java changes for compress bits operation. I've also updated the test framework.
>> Do review and share feedback.
>
> Smita Kamath has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed new line from X-Vector.java.template file

Marked as reviewed by psandoz (Committer).

test/jdk/jdk/incubator/vector/gen-template.sh line 407:

> 405: gen_binary_alu_op "XOR"   "a ^ b"   "BITWISE"
> 406: gen_binary_alu_op "COMPRESS_BITS" "CompressExpandTest.compress(a,b)" "intOrLong"
> 407: gen_binary_alu_op "EXPAND_BITS" "CompressExpandTest.expand(a,b)" "intOrLong"

Suggestion:

gen_binary_alu_op "COMPRESS_BITS" "CompressExpandTest.compress(a, b)" "intOrLong"
gen_binary_alu_op "EXPAND_BITS" "CompressExpandTest.expand(a, b)" "intOrLong"

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/184


More information about the panama-dev mailing list