[foreign-memaccess+abi] RFR: 8292078: Thread-safety issues in AbstractLinker implementations [v5]

Jorn Vernee jvernee at openjdk.org
Tue Aug 9 13:18:20 UTC 2022


On Tue, 9 Aug 2022 13:13:41 GMT, Per Minborg <duke at openjdk.org> wrote:

>> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use local class holders
>
> src/java.base/share/classes/jdk/internal/foreign/abi/aarch64/linux/LinuxAArch64Linker.java line 45:
> 
>> 43: public final class LinuxAArch64Linker extends AbstractLinker {
>> 44: 
>> 45:     public static LinuxAArch64Linker getInstance() {
> 
> I think the `getInstance()` method should only return `Linker`.

It could. We typically try to be as precise as possible with internal methods though.

-------------

PR: https://git.openjdk.org/panama-foreign/pull/702


More information about the panama-dev mailing list