[foreign-memaccess+abi] RFR: Rename and fix issues around CABI

[Maurizio Cimadamore]

On Tue, 9 Aug 2022 14:47:07 GMT, Per Minborg <duke at openjdk.org> wrote:

> I suggest renaming some variables to conform to naming conventions.
> This PR also contains other minor fixes.

Looks good - left some comments re. Aarch64 naming.

src/java.base/share/classes/jdk/internal/foreign/CABI.java line 34:

> 32:     SYS_V,
> 33:     WIN_64,
> 34:     LINUX_A_ARCH_64,

I think A_ARCH looks (subjectively) odd. LINUX_AARCH_64 seems better (even though I know two leading letter are capitals).

src/java.base/share/classes/jdk/internal/foreign/abi/SharedUtils.java line 75:

> 73:     private static final MethodHandle MH_ALLOC_BUFFER;
> 74:     private static final MethodHandle MH_BUFFER_COPY;
> 75:     private static final MethodHandle MH_REACHABILITY_FENCE;

well spotted!

-------------

Marked as reviewed by mcimadamore (Committer).

PR: https://git.openjdk.org/panama-foreign/pull/703