[foreign-memaccess+abi] RFR: 8292174: Add unaligned layouts to ValueLayout [v4]

Maurizio Cimadamore mcimadamore at openjdk.org
Fri Aug 12 13:55:33 UTC 2022


On Fri, 12 Aug 2022 13:47:39 GMT, Per Minborg <duke at openjdk.org> wrote:

>> The layouts are placed in a special `Unaligned` class. This prevents the classes to be seen on the top level (for less cluttering) and allows lazy initialization of items that are likely not so much used.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove duplicate use of UNALIGNED

src/java.base/share/classes/java/lang/foreign/ValueLayout.java line 652:

> 650:     }
> 651: 
> 652:     // Some constants below are accessed from generated bytecode, see BindingSpecializer::emitLoadLayoutConstant

Which constants "below" ? The comment would have been perfect in the old code, but now it seems the constants have been removed?

-------------

PR: https://git.openjdk.org/panama-foreign/pull/705


More information about the panama-dev mailing list