[foreign-memaccess+abi] RFR: 8292174: Add unaligned layouts to ValueLayout [v4]

Per Minborg duke at openjdk.org
Mon Aug 15 07:20:39 UTC 2022


On Fri, 12 Aug 2022 14:45:22 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> So, before they were all in a special class (Platform) but now the public layouts are used.
>
> What I meant is: the comment you copied referred to the layout definitions which have now been removed. So I think it's better to remove the comment.
> 
> E.g. I believe the comment was meant to say: these layout constants are unused in Java code, but they are used in some of the code generated by the binding specializer (so please ignore the fact that the IDE is telling you these constants are unused).
> 
> But now we no longer need that.

OK. I thought the comment meant: "Do not change, move or remove any of these constants as they are invisibly used in bytecode generated in BindingSpecializer.". But I can remove the comment.

-------------

PR: https://git.openjdk.org/panama-foreign/pull/705


More information about the panama-dev mailing list