[vectorIntrinsics+fp16] RFR: 8290872: Extend panama-vector test automation for FP16 support [v5]

[Xiaohong Gong]

On Wed, 17 Aug 2022 04:50:44 GMT, Swati Sharma <duke at openjdk.org> wrote:

>> Hi All,
>> 
>> This PR includes generation script and template changes to support operations over Halffloat vector. The new test points have been added to cover the existing Halffloat binary operations support, and plan to incrementally increase the test coverage.
>> Please review and provide your feedback.
>> 
>> Thanks,
>> Swati Sharma
>
> Swati Sharma has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8290872: Resolved review comments.

src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractSpecies.java line 649:

> 647:         }
> 648:         // Let the assert condition true for Halffloat
> 649:         assert(s.laneType == laneType) || laneType.switchKey == LaneType.SK_HALFFLOAT  : s + "!=" + laneType;

Is it better if:


if (laneType.switchKey != LaneType.SK_HALFFLOAT) {
   assert(s.laneType == laneType) : s + "!=" + laneType;
}

test/jdk/jdk/incubator/vector/Halffloat128VectorLoadStoreTests.java line 2:

> 1: /*
> 2:  * Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

The copyright should be only "2022".

test/jdk/jdk/incubator/vector/Halffloat128VectorLoadStoreTests.java line 39:

> 37: import jdk.incubator.vector.VectorMask;
> 38: import jdk.incubator.vector.Halffloat;
> 39: import jdk.incubator.vector.HalffloatVector;

Please reorder the imports by alphabetical order. Thanks!

-------------

PR: https://git.openjdk.org/panama-vector/pull/205