[foreign-memaccess+abi] RFR: 8291826: Rework MemoryLayout Sealed Hierarchy [v2]

[Per Minborg]

On Thu, 18 Aug 2022 17:49:21 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/java.base/share/classes/java/lang/foreign/MemoryLayout.java
>>   
>>   Co-authored-by: Paul Sandoz <paul.d.sandoz at googlemail.com>
>
> src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 1159:
> 
>> 1157:     @ForceInline
>> 1158:     default byte get(ValueLayout.OfByte layout, long offset) {
>> 1159:         return (byte) ((InternalValueLayout) layout).accessHandle().get(this, offset);
> 
> `InternalValueLayout` seems an unnecessary internal abstraction since we already have an internal abstract implementation of `ValueLayout` and further the concrete value implementations are accessible to this class we can just use those (`ValueLayouts.Of{X}Impl`). We should check that performance does not regress by any changes to these access methods.

Nice catch.

-------------

PR: https://git.openjdk.org/panama-foreign/pull/710