[vectorIntrinsics+fp16] RFR: 8290872: Extend panama-vector test automation for FP16 support [v5]

[Swati Sharma]

On Wed, 17 Aug 2022 06:39:32 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> Swati Sharma has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8290872: Resolved review comments.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractSpecies.java line 649:
> 
>> 647:         }
>> 648:         // Let the assert condition true for Halffloat
>> 649:         assert(s.laneType == laneType) || laneType.switchKey == LaneType.SK_HALFFLOAT  : s + "!=" + laneType;
> 
> Is it better if:
> 
> 
> if (laneType.switchKey != LaneType.SK_HALFFLOAT) {
>    assert(s.laneType == laneType) : s + "!=" + laneType;
> }

With this approach an extra check will be required for each lane type, which can be avoided by OR short circuiting.

-------------

PR: https://git.openjdk.org/panama-vector/pull/205