[foreign-memaccess+abi] RFR: 8292918: Split FunctionDescriptor into an interface and implementation(s)

[Athijegannathan Sundararajan]

On Thu, 25 Aug 2022 18:38:40 GMT, Per Minborg <duke at openjdk.org> wrote:

> This PR splits the current FunctionDescription class into an interface and two internal implementing classes.

src/java.base/share/classes/jdk/internal/foreign/FunctionDescriptorImpl.java line 2:

> 1: /*
> 2:  *  Copyright (c) 2020, 2022, Oracle and/or its affiliates. All rights reserved.

New source. No need for 2020

src/java.base/share/classes/jdk/internal/foreign/FunctionDescriptorImpl.java line 219:

> 217:             for (MemoryLayout layout : addedLayouts) {
> 218:                 requireNonNull(layout);
> 219:             }

Do we need to enforce other problems (index, null) before throwing UnsupportedOperationException? Existing code unconditionally throws UnsupportedOperationException.

src/java.base/share/classes/jdk/internal/foreign/FunctionDescriptorImpl.java line 225:

> 223:         @Override
> 224:         public FunctionDescriptorImpl changeReturnLayout(MemoryLayout newReturn) {
> 225:             requireNonNull(newReturn);

Do we need to enforce other problems (index, null) before throwing UnsupportedOperationException? Existing code unconditionally throws UnsupportedOperationException.

-------------

PR: https://git.openjdk.org/panama-foreign/pull/713