[foreign-memaccess+abi] RFR: 8292957: Remove redundant MemoryLayout::is* methods

Athijegannathan Sundararajan sundar at openjdk.org
Fri Aug 26 09:03:11 UTC 2022


On Fri, 26 Aug 2022 08:49:03 GMT, Per Minborg <duke at openjdk.org> wrote:

> This PR removes the public API methods `MemoryLayout::isPadding`, `GroupLayout::isStruct`, and `GroupLayout::isSequence`. Now that the `MemoryLayout` sealed hierarchy provides the same information, these redundant methods should be removed for reasons of consistency, symmetry, brevity, and simplicity.
> 
> See the details and proposed replacements in https://bugs.openjdk.org/browse/JDK-8292957

LGTM

src/java.base/share/classes/jdk/internal/foreign/abi/x64/sysv/TypeClass.java line 27:

> 25: package jdk.internal.foreign.abi.x64.sysv;
> 26: 
> 27: import java.lang.foreign.*;

Please restore specific imports to avoid "*" imports. (other files too).

-------------

Marked as reviewed by sundar (Committer).

PR: https://git.openjdk.org/panama-foreign/pull/714


More information about the panama-dev mailing list