[foreign-memaccess+abi] RFR: Add benchmark
Maurizio Cimadamore
mcimadamore at openjdk.org
Fri Dec 16 12:58:13 UTC 2022
On Fri, 16 Dec 2022 12:35:23 GMT, Per Minborg <pminborg at openjdk.org> wrote:
> This PR proposed to add a new benchmark outlining potential performance gains with the FFM API in internal JDK classes.
Looks good!
test/micro/org/openjdk/bench/java/lang/foreign/MemorySegmentVsBits.java line 2:
> 1: /*
> 2: * Copyright (c) 2021, 2022, Oracle and/or its affiliates. All rights reserved.
Nit: should this be 2022?
test/micro/org/openjdk/bench/java/lang/foreign/MemorySegmentVsBits.java line 100:
> 98: @Benchmark
> 99: public void panamaHeap() {
> 100: // for (int i = 0, o = 0; i < size; i++, o += 8) {
Should we drop this line?
-------------
Marked as reviewed by mcimadamore (Committer).
PR: https://git.openjdk.org/panama-foreign/pull/761
More information about the panama-dev
mailing list