[vectorIntrinsics+fp16] RFR: 8290204: FP16 initial backend implementation [v3]

Smita Kamath svkamath at openjdk.org
Wed Dec 21 22:19:19 UTC 2022


On Thu, 14 Jul 2022 17:53:15 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Smita Kamath has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressed review comments
>
> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 7765:
> 
>> 7763:     StubRoutines::x86::_vector_halffloat_sign_mask = generate_vector_fp_mask("vector_halffloat_sign_mask", 0x7FFF7FFF7FFF7FFF);
>> 7764:     StubRoutines::x86::_vector_halffloat_sign_flip = generate_vector_fp_mask("vector_halffloat_sign_flip", 0x8000800080008000);
>> 7765: 
> 
> Should be added to 32 bit stubGenerators also.

done

> src/hotspot/cpu/x86/vm_version_x86.hpp line 369:
> 
>> 367:     decl(GFNI,              "gfni",              48) /* Vector GFNI instructions */ \
>> 368:     decl(AVX512_BITALG,     "avx512_bitalg",     49) /* Vector sub-word popcount and bit gather instructions */\
>> 369:     decl(AVX512_FP16,       "avx512_fp16",       50) /* Vector FP16 instructions*/
> 
> Please also handle the newly added feature in 
> src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.amd64/src/jdk/vm/ci/amd64/AMD64.java

done

-------------

PR: https://git.openjdk.org/panama-vector/pull/204


More information about the panama-dev mailing list