[foreign-preview] RFR: 8281595: ASM-ify scope acquire/release for down call parameters [v2]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Tue Feb 15 15:01:19 UTC 2022


On Tue, 15 Feb 2022 14:53:55 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> There is only a scope slot local for Addressable and NativeSymbol parameters. Not for primitives. See the logic that initializes `scopeSlots`:
>> 
>> 
>> scopeSlots = Arrays.copyOf(scopeSlots, numScopes); // fit to size
>> 
>> 
>> (the array is the size of the parameter list initially, but is adjusted downwards. Maybe that should be made clearer...)
>
> I've tried to clarify the code that creates `scopeSlots` a bit by using a local variable for the intermediate array, instead of storing it in the field.

Thanks - I've missed that

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/640


More information about the panama-dev mailing list