[foreign-preview] RFR: 8281855: Rename ResourceScope to MemorySession
Jorn Vernee
jvernee at openjdk.java.net
Wed Feb 16 21:24:31 UTC 2022
On Tue, 15 Feb 2022 17:32:50 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
> This patch implements some of the changes described in [1] and [2]. More specifically, the `ResourceScope` abstraction is renamed into `MemorySession`, and the session accessors in `MemorySegment`, `NativeSymbol` and `VaList` are tweaked to return *non-closeable* session views. To counteract this change, `MemorySession` now supports `equals` and `hashCode`, so that sessions views can be compared to each other in ways that are not identity-sensitive.
>
> [1] - https://mail.openjdk.java.net/pipermail/panama-dev/2022-February/016152.html
> [2] - https://mail.openjdk.java.net/pipermail/panama-dev/2022-February/016254.html
src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template line 306:
> 304: if (scope != null) {
> 305: if (scope.ownerThread() == null && scope.isCloseable()) {
> 306: throw new UnsupportedOperationException("ByteBuffer derived from closeable shared segments not supported");
Reviewer note: does user have the power to create non-closeable shared segments now?
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/641
More information about the panama-dev
mailing list