[vectorIntrinsics] RFR: 8281562:[vectorapi] Add support for popcount operation [v4]

[Paul Sandoz]

On Fri, 18 Feb 2022 02:52:06 GMT, Smita Kamath <svkamath at openjdk.org> wrote:

>> 8281562:[vectorapi] Add support for popcount operation
>
> Smita Kamath has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adding bitCount support for byte and short types. Added test case in the test framework

Test update looks good.

src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template line 685:

> 683:                     v0.uOp(m, (i, a) -> ($type$) Math.abs(a));
> 684: #if[!FP]
> 685: #if[!double]

No need for `#if[!double]` ?

src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template line 693:

> 691: #end[intOrLong]
> 692: #end[!double]
> 693: #end[!FP]

Suggestion:

#end[!FP]

src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template line 2047:

> 2045: #end[!intOrLong]
> 2046: #end[!double]
> 2047: #end[!FP]

Suggestion:

#end[!FP]

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/173