[foreign-preview] RFR: 8280721: Rewrite binding of foreign classes to use javaClasses.h/cpp [v3]

[Maurizio Cimadamore]

On Mon, 21 Feb 2022 16:14:36 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Hi,
>> 
>> This patch is a refactoring of the binding between the VM and several Java classes using by the linker.
>> 
>> The usual way of creating such mappings is by declaring a C++ companion class in javaClasses.(h/c)pp, but because the bound Javas classes were previously in an incubator module, that wasn't possible.
>> 
>> Now that we have moved to java.base, we can create the missing C++ companion classes, and remove the code that did ad-hoc lookup of field offsets in the constructor of the ForeignGlobals class in the VM.
>> 
>> Additionally, this patch also removes 2 proxy classes (VMStorageProxy and ABIDescriptorProxy) that are no longer needed. As well as move NativeEntryPoint from the jdk.internal.invoke package to the jdk.internal.foreign package, since it was the only class in that package.
>> 
>> Thanks,
>> Jorn
>
> Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
> 
>  - Drop incorrect imports
>  - Fix spurious semantics change
>  - Merge branch 'foreign-preview' into Move_Internal_Invoke
>  - Merge branch 'foreign-preview' into Move_Internal_Invoke
>  - Remove unimplemented NativeCallConv::print_on
>  - Add direct javaClasses bindings for panama foreign classes
>  - Remove jdk.internal.invoke package

Looks good

-------------

Marked as reviewed by mcimadamore (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/634