[foreign-jextract] RFR: 8282235: jextract crashes when a Java keyword is used in as a function pointer typedef parameter name

Maurizio Cimadamore mcimadamore at openjdk.java.net
Tue Feb 22 17:43:13 UTC 2022


On Tue, 22 Feb 2022 17:29:33 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/FunctionalInterfaceBuilder.java line 72:
>> 
>>> 70:             name = parameterNames.get().get(i);
>>> 71:         }
>>> 72:         return name.isEmpty()? "_x" + i : Utils.javaSafeIdentifier(name);
>> 
>> Do we do this for regular native functions?
>> 
>> e.g.
>> 
>> int foo(int abstract);
>
> We already call Utils.javaSafeIdentifier() elsewhere. So this is already taken care of (8261893)

thanks for the explanation

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/653


More information about the panama-dev mailing list