[foreign-memaccess+abi] RFR: 8277845: Clean up use if ProgrammableInvoker/UpcallHandler.USE_INTRINSICS in tests. [v3]

Jorn Vernee jvernee at openjdk.java.net
Tue Jan 18 14:10:55 UTC 2022


On Tue, 11 Jan 2022 00:28:43 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   re-add /manual which was dropped by accident
>
> test/jdk/java/foreign/TestUpcallBase.java line 50:
> 
>> 48: 
>> 49:     static {
>> 50:         System.loadLibrary("TestUpcall");
> 
> Any reason why the load library calls are all defined here?

I left them there since the async and scope tests uses both TestUpcall. But I think it's probably better to move them to the specific test files (with a little duplication).

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/629


More information about the panama-dev mailing list