[foreign-memaccess+abi] RFR: 8277845: Clean up use if ProgrammableInvoker/UpcallHandler.USE_INTRINSICS in tests. [v4]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Tue Jan 18 15:02:43 UTC 2022


On Tue, 18 Jan 2022 14:54:40 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> This PR cleans up use of USE_INTRINSICS flags in the tests, which was removed a while ago.
>> 
>> I also noticed that TestMatrix.java didn't have a copyright header, so I've added one. (the diff looks a little mangled as a result). It also wasn't setting the UPCALL_TEST_TYPE flag when running TestUpcall, so I've added that flag.
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   - Move LoadLibrary calls to base classes.
>   - Make static field only used in the base class private.
>   - Capitalize static field names.

Looks good

-------------

Marked as reviewed by mcimadamore (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/629


More information about the panama-dev mailing list