[foreign-memaccess+abi] RFR: 8276647: Remove C2 trivial call intrinsification support [v2]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Thu Jan 20 13:36:41 UTC 2022


On Thu, 20 Jan 2022 13:33:24 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Hi,
>> 
>> This patch removes the C2 support for trivial call intrinsification, which is currently unused. (see also the JBS issue for a brief discussion).
>> 
>> Besides all the code that is removed by this patch, there is one 'logical' change as well: currently we are encoding `VMStorage[]` as `long[]` in `NativeEntryPoint::make`, but this is no longer needed, and I now can pass the `VMStorage[]` to native code directly. This allows removing the `vmstorage_to_vmreg` & `vmStorageToVMReg` function pair. `parse_vmstorage` is used in the native code instead. (see the code changes in NativeEntryPoint.java & nativeEntryPoint.cpp).
>> 
>> Thanks,
>> Jorn
>
> Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
> 
>  - Merge branch 'foreign-memaccess+abi' into Remove_Trivial
>  - Remove spurious includes
>  - Remove WeakReferenceCache for now
>  - Rebase fixes
>  - Remove more isTrivial, add WeakReferenceCache to NativeEntryPoint
>  - Remove ciNativeEntryPoint
>  - Remove C2 support for trivial native calls

Java changes look good! (Honestly even JVM changes look good, since it's mostly removal of code :-) )

-------------

Marked as reviewed by mcimadamore (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/609


More information about the panama-dev mailing list