[foreign-preview] RFR: 8280527: Move jdk.incubator.foreign to java.lang.foreign

Julia Boes jboes at openjdk.java.net
Tue Jan 25 18:04:14 UTC 2022


On Tue, 25 Jan 2022 12:52:25 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> To prepare for preview, this change removes the jdk.incubator.foreign module and moves the public classes to java.base/java.lang.foreign, implementation classes to java.base/jdk.internal.foreign respectively. 
>> 
>> While here, `SystemLookup` is replaced with the method `ClassLoader::findNative` and the methods in `MemoryHandles` are moved to `MethodHandles`. The `@PreviewFeature(feature=PreviewFeature.Feature.FOREIGN)` annotation and the `--enable-preview` flag are added were needed.
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 7929:
> 
>> 7927:      */
>> 7928:     @PreviewFeature(feature=PreviewFeature.Feature.FOREIGN)
>> 7929:     public static VarHandle memoryAccessVarHandle(ValueLayout layout) {
> 
> I was looking at the byte buffer VH factory which is called `byteBufferViewVarHandle` - perhaps we should use a similar scheme like `segmentViewVarHandle` ? (we can address this separately)

Addressing this in https://bugs.openjdk.java.net/browse/JDK-8280597

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/633


More information about the panama-dev mailing list